Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options to disable saving <player>.dat #14

Merged
merged 2 commits into from
Oct 7, 2016
Merged

Conversation

dktapps
Copy link
Member

@dktapps dktapps commented Oct 7, 2016

Some server owners do not want to have player data saved due to the fact that players' data should be/will be reset next time they join. Saving such unnecessary data wastes processing and disk time and can also be a nuisance for large servers saving useless/unwanted data for thousands of players. Examples of this are minigame servers, where the player will always start from zero when they join.

References: iTXTech/Genisys#2035

This pull requests adds an option to pocketmine.yml to disable the saving of <player>.dat.

Copy link
Member

@SOF3 SOF3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the notice that is shown when a player joins a server and his dat file is not found, if !shouldSavePlayerData()..

@SOF3 SOF3 added Category: Core Related to internal functionality PR: Addition of features labels Oct 7, 2016
@dktapps
Copy link
Member Author

dktapps commented Oct 7, 2016

Tested this, working flawlessly. Ready to merge?

@SOF3 SOF3 merged commit beabc5a into master Oct 7, 2016
@dktapps dktapps deleted the disable-player-dat branch October 7, 2016 10:49
@Renual1337 Renual1337 mentioned this pull request May 7, 2017
@SuperKali SuperKali mentioned this pull request Nov 25, 2017
@nobody5050 nobody5050 mentioned this pull request Jan 6, 2018
@ManiakMCPE ManiakMCPE mentioned this pull request Dec 14, 2018
@3zeroed 3zeroed mentioned this pull request Dec 14, 2018
This was referenced Dec 15, 2018
@hachkingtohach1 hachkingtohach1 mentioned this pull request Jul 13, 2020
@Crasher508 Crasher508 mentioned this pull request Jul 13, 2020
@ghost ghost mentioned this pull request Jul 19, 2020
@shurkeel12 shurkeel12 mentioned this pull request Nov 27, 2020
@ghost ghost mentioned this pull request Apr 8, 2021
@aref0448 aref0448 mentioned this pull request Apr 27, 2021
@PLATONG98 PLATONG98 mentioned this pull request May 4, 2021
@Willtom999 Willtom999 mentioned this pull request Jun 8, 2021
@jaylac2000 jaylac2000 mentioned this pull request Jul 9, 2021
@StefanFox-Dev StefanFox-Dev mentioned this pull request May 26, 2022
@PmmpDevelop PmmpDevelop mentioned this pull request Aug 9, 2022
@dktapps dktapps added Type: Enhancement Contributes features or other improvements to PocketMine-MP and removed Type: Contribution labels Nov 26, 2022
@ahnsunggwan45 ahnsunggwan45 mentioned this pull request May 30, 2023
@ahnsunggwan45 ahnsunggwan45 mentioned this pull request Jun 27, 2023
@GabBiswajit GabBiswajit mentioned this pull request Jul 6, 2023
@TamaoD TamaoD mentioned this pull request Jul 19, 2023
@KohakuChan-Dev KohakuChan-Dev mentioned this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core Related to internal functionality Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants