Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to 0.15.10 #13

Closed
wants to merge 2 commits into from
Closed

Bump to 0.15.10 #13

wants to merge 2 commits into from

Conversation

NoHaxJustTryHqrd
Copy link
Contributor

No description provided.

@dktapps
Copy link
Member

dktapps commented Oct 5, 2016

And did you actually test this properly, or just assume that because you were able to join that it was production-ready?
You make the same mistake everyone does. The protocol number is simply a version number. Modifying it does not cater for actual changes.
This pull request also does not comply with our contribution guidelines.

SOF3
SOF3 requested changes Oct 5, 2016
View reviewed changes
Copy link
Member

@SOF3 SOF3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not help the project at all. It is much more convenient to change the version number ourselves directly than merging a pull request, and we are not bumping the version number for some reasons. Please show, or at least, declare that you have confirmed there are indeed no otherwise protocol changes in this protocol bump.

@SOF3 SOF3 added Category: Client Related to Mojang client (usually client-caused bugs) Category: Protocol update labels Oct 5, 2016
@robske110
Copy link
Contributor

This protocol bump has to do sth with capes/skin handling. Not breaking the current code in any way, we do not (yet) read/write/send cape data.

@NoHaxJustTryHqrd
Copy link
Contributor Author

This does not break any code in any way as 0.15.10 only added skins

@dktapps
Copy link
Member

dktapps commented Oct 5, 2016

This does not break any code in any way as 0.15.10 only added skins

that you know about. Protocol changes are not documented in the changelogs.

@SOF3
Copy link
Member

SOF3 commented Oct 5, 2016 •
edited
Loading

@robske110 please prove or confirm that this protocol dump only involves skins/capes information.

@NoHaxJustTryHqrd
Copy link
Contributor Author

I will fully test this very soon when i do ill get back to you

@dktapps dktapps closed this Oct 5, 2016
@NoHaxJustTryHqrd
Copy link
Contributor Author

Tested. Production ready. Up to you to merge

@pmmp pmmp locked and limited conversation to collaborators Oct 5, 2016
@SOF3
Copy link
Member

SOF3 commented Oct 5, 2016 •
edited
Loading

The CONTRIBUTING.md will be updated soon to disallow this kind of pull requests which contribute as little as updating minor values that we know that we have to change (unlike typos, which we aren't aware of) but have not done so yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SOF3 SOF3 SOF3 requested changes

Assignees
No one assigned
Labels
Category: Client Related to Mojang client (usually client-caused bugs) Resolution: Invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NoHaxJustTryHqrd @dktapps @robske110 @SOF3