Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--disable-readline command-line option does not work #34

Closed
dktapps opened this issue Oct 18, 2016 · 4 comments
Closed

--disable-readline command-line option does not work #34

dktapps opened this issue Oct 18, 2016 · 4 comments
Labels
Category: Core Related to internal functionality Resolution: Fixed

Comments

@dktapps
Copy link
Member

dktapps commented Oct 18, 2016

Issue description

readline cannot be disabled with --disable-readline if the extension is present.

Steps to reproduce the issue

  1. Run a server on a Linux box with readline PHP extension, with --disable-readline option.

OS and versions

  • PocketMine-MP: d53810c
  • PHP: 7.0.10 with readline extension
  • Server OS: Any Linux distro
  • Game version: irrelevant
@dktapps dktapps added Status: Reproduced Bug has been reproduced, but cause has not yet been identified Category: Core Related to internal functionality labels Oct 18, 2016
@legoboy0215
Copy link
Contributor

Off-topic: Why would you want to disable readline? Or is there no particular reason?

@dktapps
Copy link
Member Author

dktapps commented Oct 18, 2016

We initially discovered this issue in Travis with a spam of > > > > >

dktapps added a commit that referenced this issue Oct 18, 2016
@dktapps
Fix --disable-readline command-line option does not work, close #34
e4c5974
@SOF3
Copy link
Member

SOF3 commented Oct 18, 2016 •
edited
Loading

Clarification: --disable-readline is to disable use of the extension readline's function readline() and use fgets(STDIN) instead, not to disable stdin.

@legoboy0215
Copy link
Contributor

Oh ok.

@dktapps dktapps added Status: Debugged Cause of the bug has been found, but not fixed and removed Status: Reproduced Bug has been reproduced, but cause has not yet been identified labels Oct 18, 2016
dktapps added a commit that referenced this issue Oct 18, 2016
@dktapps
Fix --disable-readline command-line option does not work, close #34
89c3666
@dktapps dktapps added Resolution: Fixed and removed Status: Debugged Cause of the bug has been found, but not fixed labels Oct 18, 2016
@Renual1337 Renual1337 mentioned this issue May 7, 2017
Closed
@hachkingtohach1 hachkingtohach1 mentioned this issue Jul 26, 2019
Closed
@ghost ghost mentioned this issue Jul 19, 2020
Closed
@krake79 krake79 mentioned this issue Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Core Related to internal functionality Resolution: Fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@legoboy0215 @dktapps @SOF3