-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion of spans leads to invalid blocks and drops images #21
Comments
Similar to #20 -- thanks for the specific case |
The new results don't seem right. The images are still dropped. All these do not return a image-block: The changes span seems to work but I expected it to be dropped. |
Looking into it
…On Sun, Mar 5, 2023, 16:08 Philip Bauer ***@***.***> wrote:
Reopened #21 <#21>.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKWXRHHAQZEVPPNVB5MWTW2TQDBANCNFSM6AAAAAAVOXTKV4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
com>
|
@pbauer Additional tests implemented on Release 0.4.6 (And on main) |
Source is an empty span:
Result:
Problem:
On editing it raises
Error: Cannot get the start point in the node at path [0] because it has no start text node.
Source is a span with a image
Result (same as above):
Problem:
The image is dropped. On editing it again raises
Error: Cannot get the start point in the node at path [0] because it has no start text node.
Source is a span with image and text
Result
Problem:
The image is dropped, the block is valid
The text was updated successfully, but these errors were encountered: