Fixing (I believe) #25

playgameservices · Mar 17, 2014 · 480e8f3 · 480e8f3
1 parent 6c8da15
commit 480e8f3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/source/PluginDev/Assets/GooglePlayGames/Platforms/Android/GameHelperManager.cs b/source/PluginDev/Assets/GooglePlayGames/Platforms/Android/GameHelperManager.cs
@@ -163,10 +163,12 @@ void OnSignInSucceeded(int origin) {
             if (origin == ORIGIN_MAIN_ACTIVITY) {
                 mAndroidClient.OnSignInSucceeded();
             } else if (origin == ORIGIN_SIGN_IN_HELPER_ACTIVITY) {
-                // the sign in helper Activity succeeded sign in, so we are ready to
-                // start setting up our GameHelper.
-                Logger.d("GHM got helper's OnSignInSucceeded, so calling GameHelper.onStart");
-                mGameHelper.Call("onStart", mAndroidClient.GetActivity());
+                // the sign in helper Activity succeeded sign in
+                Logger.d("GHM got helper's OnSignInSucceeded.");
+                // we don't need to do anything here because as soon as the sign in helper
+                // activity is finished, we will get OnResume() and then we'll try to
+                // reconnect our GameHelper, which will result in a success.
+                // DO NOT CALL mGameHelper.Call("onStart", mAndroidClient.GetActivity()) HERE.
             }
         }
 

diff --git a/...ortLib/BaseGameUtils/src/main/java/com/google/example/games/basegameutils/GameHelper.java b/...ortLib/BaseGameUtils/src/main/java/com/google/example/games/basegameutils/GameHelper.java
@@ -589,7 +589,6 @@ public void beginUserInitiatedSignIn() {
         } else {
             // We don't have a pending connection result, so start anew.
             debugLog("beginUserInitiatedSignIn: starting new sign-in flow.");
-            mConnecting = true;
             connect();
         }
     }