Generalize ProtectionProfiles #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't change any APIs, just moved all the AES-CM stuff into their own files! Wanted to get this refactoring/changes in its own commit to make debugging easier if anything happens. When this gets approved will open up AES-GCM in next commit! |
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 77.60% 77.65% +0.04%
==========================================
Files 11 14 +3
Lines 661 716 +55
==========================================
+ Hits 513 556 +43
- Misses 83 90 +7
- Partials 65 70 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This removes a lot of profile specific constants and insteads put them behind the profile. Key, Salt and TagLen need to be determined by the profile. Relates to #85
at-wat
approved these changes
Jul 17, 2020
| ProtectionProfileAes128CmHmacSha1_80 ProtectionProfile = 0x0001 | ||
| ) | ||
|
|
||
| func (p ProtectionProfile) keyLen() (int, error) { |
There was a problem hiding this comment.
These profile spec getter would be nice to be exposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a lot of profile specific constants and insteads
put them behind the profile. Key, Salt and TagLen need to be
determined by the profile.
Relates to #85