Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel Previous Gathering Routine On Restart #328

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

wawesomeNOGUI
Copy link
Member

@wawesomeNOGUI wawesomeNOGUI commented Jan 24, 2021

Description

Updated ICE agent restart method to cancel the current gathering and then restart the candidate gathering process.

Reference issue

Fixes #280

@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Base: 77.86% // Head: 77.92% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (b9d9680) compared to base (7f2d498).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head b9d9680 differs from pull request most recent head 12992ff. Consider uploading reports for the commit 12992ff to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   77.86%   77.92%   +0.06%     
==========================================
  Files          36       36              
  Lines        4237     4236       -1     
==========================================
+ Hits         3299     3301       +2     
+ Misses        729      727       -2     
+ Partials      209      208       -1     
Flag Coverage Δ
go 77.92% <100.00%> (+0.06%) ⬆️
wasm 24.59% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agent.go 82.01% <100.00%> (-0.39%) ⬇️
gather.go 66.35% <0.00%> (+0.36%) ⬆️
selection.go 84.18% <0.00%> (+1.86%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wawesomeNOGUI wawesomeNOGUI changed the title Update agent.go Cancel Previous Gathering Routine On Restart Mar 8, 2021
@stv0g stv0g self-requested a review November 12, 2022 14:27
Updated ICE agent restart method to cancel the
current gathering and then restart the candidate
gathering process.
Copy link
Member

@stv0g stv0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've squashed and rebased the changes to the latest master.

@stv0g stv0g merged commit 9ab8f71 into pion:master Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ICE Agent can not be restarted when gathering
2 participants