Refactor errors #209
Merged
Refactor errors #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daenney
reviewed
Mar 5, 2020
daenney
reviewed
Mar 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 77.09% 76.97% -0.12%
==========================================
Files 75 77 +2
Lines 4055 4086 +31
==========================================
+ Hits 3126 3145 +19
- Misses 627 636 +9
- Partials 302 305 +3
Continue to review full report at Codecov.
|
at-wat
force-pushed
the
refactor-errors
branch
6 times, most recently
from
ac70fd5 to
aa4ca69
Compare
Wrap all errors to implement net.Error. Caller of Read/Write can check err.(net.Error).Temporary() to determine whether the error is fatal or not, as with raw net.UDPConn. Split errInvalidPacketLength from errLengthMismatch. errInvalidPacketLength is used for errors caused by incoming data, which must be discarded, and errLengthMismatch is used for errors due to the data generated by the library, which is a fatal internal error.
|
rebased |
This was referenced Mar 8, 2020
Closed
Merged
daenney
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap all errors to implement net.Error.
Caller of Read/Write can check
err.(net.Error).Temporary()to determine whether the error is fatal or not, as with rawnet.UDPConn.Split
errInvalidPacketLengthfromerrLengthMismatch.errInvalidPacketLengthis used for errors caused by incoming data, which must be discarded, anderrLengthMismatchis used for errors due to the data generated by the library, which is a fatal internal error.