Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9558] Configurable flink rest port #9559

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Dec 29, 2022

Added batch.flink.rest.port property.

@smilu97 smilu97 requested a review from minwoo-jung December 29, 2022 04:13
@smilu97 smilu97 self-assigned this Dec 29, 2022
@smilu97 smilu97 changed the title [#5460] Configurable flink rest port [#9558] Configurable flink rest port Dec 29, 2022
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #9559 (6d135fc) into master (0ca18f3) will increase coverage by 0.01%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##             master    #9559      +/-   ##
============================================
+ Coverage     38.86%   38.88%   +0.01%     
- Complexity    11880    11884       +4     
============================================
  Files          3482     3482              
  Lines         93741    93734       -7     
  Branches      10525    10525              
============================================
+ Hits          36431    36445      +14     
+ Misses        54150    54126      -24     
- Partials       3160     3163       +3     
Impacted Files Coverage Δ
...corp/pinpoint/batch/common/BatchConfiguration.java 67.74% <0.00%> (+15.24%) ⬆️
...orp/pinpoint/batch/flink/HealthCheckTaskletV2.java 25.92% <50.00%> (+25.92%) ⬆️
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 72.22% <0.00%> (-3.71%) ⬇️
...corp/pinpoint/rpc/stream/StreamChannelManager.java 60.67% <0.00%> (-1.13%) ⬇️
...ollector/cluster/zookeeper/ZookeeperJobWorker.java 77.54% <0.00%> (+1.60%) ⬆️
...pinpoint/profiler/instrument/AccessorAnalyzer.java 61.29% <0.00%> (+9.67%) ⬆️
...p/pinpoint/rpc/stream/StreamChannelRepository.java 78.94% <0.00%> (+21.05%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@minwoo-jung minwoo-jung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@smilu97 smilu97 merged commit 181481e into pinpoint-apm:master Dec 29, 2022
@smilu97 smilu97 deleted the 9558_fk branch December 29, 2022 06:02
@smilu97 smilu97 linked an issue Jan 3, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flink rest port should be configurable
2 participants