Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Refactor ServerBuilder #9065

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jul 22, 2022

No description provided.

@emeroad emeroad force-pushed the #noissue_cleanup branch from 8b5241c to c1e86df Compare July 22, 2022 10:45
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #9065 (c1e86df) into master (9b96675) will increase coverage by 0.01%.
The diff coverage is 62.50%.

@@             Coverage Diff              @@
##             master    #9065      +/-   ##
============================================
+ Coverage     39.80%   39.81%   +0.01%     
+ Complexity    11830    11828       -2     
============================================
  Files          3365     3362       -3     
  Lines         90938    90925      -13     
  Branches      10090    10092       +2     
============================================
+ Hits          36194    36200       +6     
+ Misses        51647    51624      -23     
- Partials       3097     3101       +4     
Impacted Files Coverage Δ
...p/appender/server/EmptyServerGroupListFactory.java 0.00% <0.00%> (ø)
...ender/server/StatisticsServerGroupListFactory.java 0.00% <0.00%> (ø)
...web/applicationmap/nodes/NodeHistogramSummary.java 0.00% <0.00%> (ø)
...navercorp/pinpoint/web/service/MapServiceImpl.java 0.00% <0.00%> (ø)
.../web/service/ResponseTimeHistogramServiceImpl.java 0.00% <0.00%> (ø)
...t/web/service/ServerInstanceDatasourceService.java 0.00% <0.00%> (ø)
...point/web/view/NodeHistogramSummarySerializer.java 0.00% <0.00%> (ø)
...om/navercorp/pinpoint/web/view/NodeSerializer.java 0.00% <0.00%> (ø)
...om/navercorp/pinpoint/web/view/LinkSerializer.java 73.46% <33.33%> (ø)
...oint/web/applicationmap/ApplicationMapBuilder.java 80.30% <66.66%> (-0.86%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b96675...c1e86df. Read the comment docs.

@emeroad emeroad merged commit 6f23b59 into pinpoint-apm:master Jul 25, 2022
@emeroad emeroad deleted the #noissue_cleanup branch July 25, 2022 05:58
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant