Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8965] Simplified thread flow control of SharedTestLifeCycle #8998

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jun 30, 2022

No description provided.

@emeroad emeroad changed the title 8965 Add SharedTestLifeCycle to simplify plugin integration tests [#8965] Add SharedTestLifeCycle to simplify plugin integration tests Jun 30, 2022
@emeroad emeroad linked an issue Jun 30, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #8998 (56fa369) into master (516b4b5) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #8998      +/-   ##
============================================
+ Coverage     39.74%   39.76%   +0.02%     
- Complexity    11792    11793       +1     
============================================
  Files          3345     3346       +1     
  Lines         90839    90805      -34     
  Branches      10057    10053       -4     
============================================
+ Hits          36103    36110       +7     
+ Misses        51644    51602      -42     
- Partials       3092     3093       +1     
Impacted Files Coverage Δ
...t/test/plugin/shared/SharedPinpointPluginTest.java 0.00% <0.00%> (ø)
...inpoint/test/plugin/shared/SharedTestExecutor.java 0.00% <0.00%> (ø)
...test/plugin/shared/SharedTestLifeCycleWrapper.java 0.00% <0.00%> (ø)
...orp/pinpoint/test/plugin/shared/ThreadFactory.java 0.00% <0.00%> (ø)
...pinpoint/profiler/instrument/AccessorAnalyzer.java 51.61% <0.00%> (-9.68%) ⬇️
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 20.45% <0.00%> (-1.14%) ⬇️
...corp/pinpoint/rpc/stream/StreamChannelManager.java 60.67% <0.00%> (-1.13%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 72.22% <0.00%> (ø)
...n/server/bo/serializer/trace/v2/SpanDecoderV0.java 81.73% <0.00%> (+0.45%) ⬆️
...n/server/bo/serializer/trace/v2/SpanEncoderV0.java 83.42% <0.00%> (+0.53%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516b4b5...56fa369. Read the comment docs.

@emeroad emeroad merged commit cad01c8 into pinpoint-apm:master Jun 30, 2022
@emeroad emeroad changed the title [#8965] Add SharedTestLifeCycle to simplify plugin integration tests [#8965] Simplified thread flow control of SharedTestLifeCycle Jun 30, 2022
@emeroad emeroad deleted the #8965_simplified_thread branch June 30, 2022 08:12
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SharedTestLifeCycle to simplify plugin integration tests
1 participant