Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unable to detect applicationtype in the Spring Boot 3.2.X #10615

Closed
nooose opened this issue Jan 16, 2024 · 2 comments · Fixed by #10616
Closed

unable to detect applicationtype in the Spring Boot 3.2.X #10615

nooose opened this issue Jan 16, 2024 · 2 comments · Fixed by #10616
Labels
module:plugin
Milestone
3.0.0

Comments

@nooose
Copy link
Contributor

nooose commented Jan 16, 2024 •
edited
Loading

Which module is your feature request related to?
Plugin

Is your feature request related to a problem?
same title.
Server map displays the Java icon application

Describe the solution you'd like
applicationtype should be automatically detected

Describe alternatives you've considered
add the main classes for 3.2.X to SpringBootDetector class.

Additional context
read release notes
you can see new launcher classes
@nooose nooose mentioned this issue Jan 16, 2024
Merged
@donghun-cho
Copy link
Contributor

@nooose, thank you for explaination and PR.

The main classes can be configured by editing the agent configuration. The property name is profiler.springboot.bootstrap.main.

The agent configuration also needs to be changed for automatic detection. Could you please add that to your PR?

@donghun-cho donghun-cho added this to the 3.0.0 milestone Jan 16, 2024
@nooose
Copy link
Contributor Author

nooose commented Jan 16, 2024

@donghun-cho
That's right. I didn't check that.
I'll add more

nooose added a commit to nooose/pinpoint that referenced this issue Jan 16, 2024
@nooose
pinpoint-apm#10615 - add default main properties for auto detection
e54f9bd 
just in case, add it to test profiles
@donghun-cho donghun-cho linked a pull request Jan 17, 2024 that will close this issue
[#10615] Add new Main classes to SpringBootDetector #10616
Merged
nooose added a commit to nooose/pinpoint that referenced this issue Jan 17, 2024
@nooose
[pinpoint-apm#10615] Add spring boot 3.2.X default launcher classes
fcd8113
donghun-cho pushed a commit that referenced this issue Jan 18, 2024
@nooose @donghun-cho
[#10615] Add spring boot 3.2.X default launcher classes
aadaeb8
@donghun-cho donghun-cho mentioned this issue Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:plugin
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

[#10615] Add new Main classes to SpringBootDetector nooose/pinpoint
2 participants
@nooose @donghun-cho