Abort uploading checkpoint if s3 lock client is not initialized #9655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cap#318) Signed-off-by: Calvin Neo <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
ti-chi-bot
bot
added
needs-1-more-lgtm
JaySon-Huang
changed the title
breezewish
approved these changes
Nov 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
bot
added
the
needs-cherry-pick-release-8.5
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
ti-chi-bot
bot
added
size/M
Signed-off-by: Calvin Neo <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
… (#9659) close #9394 Signed-off-by: Calvin Neo <[email protected]> Co-authored-by: Calvin Neo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9394
Problem Summary:
there is a time gap after TMTContext is created but before
TMTContext::initS3GCManagerfinishedWhat is changed and how it works?
Do not init S3LocalLockManager, if the client is not set.
Check List
Tests
Side effects
Documentation
Release note