Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more resource group metrics #9427

Merged
merged 8 commits into from
Sep 12, 2024
Merged

add more resource group metrics #9427

merged 8 commits into from
Sep 12, 2024

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Sep 11, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9428

Problem Summary: AutoScaler needs new metrics:

  1. handling mpp tasks for each resource group: so it can decide which tenant can be paused
  2. request unit for each resource group: so it can decide which tenant use how much CPU

What is changed and how it works?

Check List

handling mpp tasks per resource group
zAYcl1n5or

ru per resource group:
vcVXVfDC7N

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@guo-shaoge
handling_cop_task for each resource_group
ca19017 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
request_unit
4e64029 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fmt
ed08df3 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 11, 2024
@guo-shaoge
fix
9917b2c 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 11, 2024
@guo-shaoge
fix
ebbf9cb 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 12, 2024
windtalker
windtalker approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gengliqi,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 12, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-12 04:18:10.735179446 +0000 UTC m=+502760.475603377: ☑️ agreed by gengliqi.
  • 2024-09-12 06:17:06.111464591 +0000 UTC m=+509895.851888522: ☑️ agreed by windtalker.

@guo-shaoge
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
@guo-shaoge guo-shaoge removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
@guo-shaoge
Copy link
Contributor Author

/merge

@guo-shaoge
Copy link
Contributor Author

/unhold

@guo-shaoge guo-shaoge added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
@guo-shaoge guo-shaoge removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit a458ca1 into pingcap:master Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengliqi gengliqi gengliqi approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add more resource group metrics
3 participants
@guo-shaoge @windtalker @gengliqi