-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KVStore: Refine parallel prehandle snapshot (part-3) #9198
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JaySon-Huang: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dc52cf9
to
5d0d50c
Compare
5d0d50c
to
f8420c1
Compare
What problem does this PR solve?
Issue Number: ref #8081
Problem Summary:
In the previous implementation, the code is kind of messy. We will create a
SSTFilesToBlockInputStream
, thenresetSoftLimit
a soft limit to the input stream.What is changed and how it works?
SnapshotSSTReader
to simplify the code. The following methods moved fromSSTFilesToBlockInputStream
to the new class:getApproxBytes
findSplitKeys
maybeSkipBySoftLimit
maybeStopBySoftLimit
checkFinishedState
SnapshotSSTReader
with given SoftLimit, then use the "SnapshotSSTReader with soft limit" to create "SSTFilesToBlockInputStream"Check List
Tests
Side effects
Documentation
Release note