Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #7810 #7854

Merged
merged 2 commits into from
Aug 1, 2023
Merged

fix issue #7810 #7854

merged 2 commits into from
Aug 1, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jul 27, 2023

What problem does this PR solve?

Issue Number: close #7810

Problem Summary:

What is changed and how it works?

doesn't call prepareForInputStream in doExecuteAsBlockIO

void prepareForInputStream(
    Context & context,
    const BlockInputStreamPtr & in)
{
    assert(in);
    if (auto * stream = dynamic_cast<IProfilingBlockInputStream *>(in.get()))
    {
        stream->setProgressCallback(context.getProgressCallback());
        stream->setProcessListElement(context.getProcessListElement());
    }
}

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 27, 2023

/run-all-tests

@SeaRise SeaRise changed the title .*: fix issue #7810 fix issue #7810 Jul 27, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 27, 2023

/run-all-tests

@SeaRise SeaRise requested a review from windtalker July 28, 2023 03:18
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 31, 2023
@SeaRise SeaRise requested a review from yibin87 July 31, 2023 09:37
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 1, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-31 09:31:06.224218779 +0000 UTC m=+91350.166567310: ☑️ agreed by windtalker.
  • 2023-08-01 01:07:43.539668409 +0000 UTC m=+147547.482016925: ☑️ agreed by yibin87.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2023

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@windtalker
Copy link
Contributor

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 1, 2023

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 80f8e9d into pingcap:master Aug 1, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 1, 2023
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #7870.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 1, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 1, 2023
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7871.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 1, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7872.

This was referenced Aug 1, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #7873.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 1, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #7874.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 1, 2023
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 1, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Aug 1, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Aug 9, 2023
@SeaRise SeaRise deleted the fix_issue_7810 branch December 4, 2023 06:07
ti-chi-bot bot pushed a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
4 participants