Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote read DagRequest has incorrect flags field #8607

Closed
yibin87 opened this issue Dec 27, 2023 · 0 comments · Fixed by #8606
Closed

Remote read DagRequest has incorrect flags field #8607

yibin87 opened this issue Dec 27, 2023 · 0 comments · Fixed by #8606
Assignees
@yibin87
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/compute priority/P1 The issue has P1 priority. severity/major type/bug The issue is confirmed as a bug.

Comments

@yibin87
Copy link
Contributor

yibin87 commented Dec 27, 2023 •
edited
Loading

When we build RemoteRequest in following function, we don't set DagRequest's flags field, leaving it default value. The falgs field will decide if TiFlash should ignore certain warnings:
https://github.com/pingcap/tiflash/blob/cea7c80823e05173db7983bd6eecf0b81dc96761/dbms/src/Flash/Coprocessor/RemoteRequest.cpp#L24C1-L32C27
It may cause problems if the DagRequest contains filter operations and these filter operations produce truncate warning or other warnings.
@yibin87 yibin87 added the type/bug The issue is confirmed as a bug. label Dec 27, 2023
@yibin87 yibin87 mentioned this issue Dec 27, 2023
Merged
12 tasks
@yibin87 yibin87 self-assigned this Dec 27, 2023
@yibin87 yibin87 added priority/P1 The issue has P1 priority. severity/major component/compute affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Dec 27, 2023
ti-chi-bot bot pushed a commit that referenced this issue Dec 27, 2023
@yibin87
Set remote requst's DagRequest flags field (#8606)
813f475 
close #8607
@ti-chi-bot ti-chi-bot mentioned this issue Dec 27, 2023
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this issue Dec 27, 2023
@yibin87 @ti-chi-bot
Set remote requst's DagRequest flags field (pingcap#8606)
e7746f8 
close pingcap#8607
@ti-chi-bot ti-chi-bot mentioned this issue Dec 27, 2023
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this issue Dec 27, 2023
@yibin87 @ti-chi-bot
Set remote requst's DagRequest flags field (pingcap#8606)
dd74c1a 
close pingcap#8607
@ti-chi-bot ti-chi-bot mentioned this issue Dec 27, 2023
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this issue Dec 27, 2023
@yibin87 @ti-chi-bot
Set remote requst's DagRequest flags field (pingcap#8606)
c867c37 
close pingcap#8607
@ti-chi-bot ti-chi-bot mentioned this issue Dec 27, 2023
Merged
12 tasks
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this issue Dec 27, 2023
@yibin87 @JaySon-Huang
Set remote requst's DagRequest flags field (pingcap#8606)
b270e26 
close pingcap#8607
ti-chi-bot bot pushed a commit that referenced this issue Dec 28, 2023
@ti-chi-bot
Set remote requst's DagRequest flags field (#8606) (#8611)
b66f685 
close #8607
ti-chi-bot bot pushed a commit that referenced this issue Dec 28, 2023
@ti-chi-bot
Set remote requst's DagRequest flags field (#8606) (#8610)
9f143b9 
close #8607
ti-chi-bot bot pushed a commit that referenced this issue Dec 28, 2023
@ti-chi-bot
Set remote requst's DagRequest flags field (#8606) (#8609)
0b20c02 
close #8607
ti-chi-bot bot pushed a commit that referenced this issue Dec 28, 2023
@ti-chi-bot
Set remote requst's DagRequest flags field (#8606) (#8612)
2ffe43c 
close #8607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yibin87 yibin87

Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/compute priority/P1 The issue has P1 priority. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set remote requst's DagRequest flags field yibin87/tiflash
1 participant
@yibin87