LAC::consumeResource may introduce performance regression

[guo-shaoge]

Bug Report

Please answer these questions before submitting your issue. Thanks!

https://github.com/pingcap/tiflash/blob/master/dbms/src/Storages/DeltaMerge/SkippableBlockInputStream.h#L224 and https://github.com/pingcap/tiflash/blob/master/dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileSetReader.cpp#L194 will consume resource for storage layer, but there are situations that the calling of LAC::consumeResource are too frequent, which may introduce significant regression.

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)

[Yui-Song]

As the issue causes a 17%- 31% performance regression in CH benchmark, which will block the release of v7.5.0. Adjust its severity to critical.
/remove-severity major
/severity critical

[Yui-Song]

/remove-label may-affects-5.3
/remove-label may-affects-5.4
/remove-label may-affects-6.1
/remove-label may-affects-6.5
/remove-label may-affects-7.1

[ti-chi-bot]

@Yui-Song: The label(s) may-affects-5.3, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1 cannot be applied. These labels are supported: tide/merge-method-rebase, tide/merge-method-squash, tide/merge-method-merge, duplicate, first-time-contributor, good first issue, ok-to-test, needs-ok-to-test, help wanted, invalid, question, wontfix, make-local-great-again, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-rebase.

In response to this:

/remove-label may-affects-5.3
/remove-label may-affects-5.4
/remove-label may-affects-6.1
/remove-label may-affects-6.5
/remove-label may-affects-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[Yui-Song]

/remove-label may-affects-5.3

[ti-chi-bot]

@Yui-Song: The label(s) may-affects-5.3 cannot be applied. These labels are supported: tide/merge-method-rebase, tide/merge-method-squash, tide/merge-method-merge, duplicate, first-time-contributor, good first issue, ok-to-test, needs-ok-to-test, help wanted, invalid, question, wontfix, make-local-great-again, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-rebase.

In response to this:

/remove-label may-affects-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.