Merge pull request #347 from azf20/patch-1

use localOwners in signUserOperation on toSafeSmartAccount
pimlicolabs · Jan 8, 2025 · 8fb7862 · 8fb7862
2 parents c83d398 + bae15ee
commit 8fb7862
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/.changeset/four-eggs-deny.md b/.changeset/four-eggs-deny.md
@@ -0,0 +1,5 @@
+---
+"permissionless": patch
+---
+
+Fixed `signUserOperation` for `toSafeSmartAccount` when owner is not a LocalAccount.
diff --git a/packages/permissionless-test/src/testWithRpc.ts b/packages/permissionless-test/src/testWithRpc.ts
@@ -30,11 +30,16 @@ export const getInstances = async ({
         | string
         | undefined
 
-    const anvilInstance = anvil({
-        chainId: foundry.id,
-        port: anvilPort,
-        forkUrl
-    })
+    const anvilInstance = forkUrl
+        ? anvil({
+              chainId: foundry.id,
+              port: anvilPort,
+              forkUrl
+          })
+        : anvil({
+              chainId: foundry.id,
+              port: anvilPort
+          })
 
     const altoInstance = alto({
         entrypoints: [entryPoint06Address, entryPoint07Address],

diff --git a/packages/permissionless/accounts/safe/toSafeSmartAccount.ts b/packages/permissionless/accounts/safe/toSafeSmartAccount.ts
@@ -1525,7 +1525,7 @@ export async function toSafeSmartAccount<
 
             let signatures: Hex | undefined = undefined
 
-            for (const owner of owners) {
+            for (const owner of localOwners) {
                 signatures = await signUserOperation({
                     ...userOperation,
                     version,