Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSMPT v3.0.8 pull request #180

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

BSMPT v3.0.8 pull request #180

wants to merge 13 commits into from

Conversation

vollous
Copy link
Collaborator

@vollous vollous commented Nov 28, 2024 •
edited
Loading

Change log

  • Small changes to prepareData_*.py scripts.
  • Changes to the python model implementation method.
  • Mathematica model implementation method

@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.18919% with 16 lines in your changes missing coverage. Please review.

Project coverage is 83.39%. Comparing base (7302d69) to head (26500e5).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/models/modeltests/ModelTestfunctions.cpp 88.99% 12 Missing ⚠️
src/transition_tracer/transition_tracer.cpp 89.74% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   83.36%   83.39%   +0.03%     
==========================================
  Files          54       54              
  Lines       18770    19385     +615     
  Branches     1847     1852       +5     
==========================================
+ Hits        15647    16166     +519     
- Misses       3123     3219      +96
Flag Coverage Δ
unittests 83.39% <89.18%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vollous and others added 3 commits December 11, 2024 15:35
@vollous @lisabiermann
Mathematica model implementation (#171)
0478ad4 
* Mathematica implementation

* Small improvements

* Automate model implementation (src still not implemented)

* N2HDM full mathematica implementation

* nQuark nGauge nLepton different from SM support. Still has to be tested.

* Update tools/ModelGeneration/Mathematica/N2HDM.m

Co-authored-by: Lisa Biermann <[email protected]>

* Update tools/ModelGeneration/Mathematica/CreateModel.m

Co-authored-by: Lisa Biermann <[email protected]>

* Remove "21" to nRows of EqMatrix

* Import Helper functions at the end

* Remove some errors

* Move helper function to the beginning

* Moved "InputParameters"

* Fix test not passing. All dependent vars need to be defined as function of the input parameters.

* More appropriate name

* Example file is created right away with some values set by the user

* Removing warning

* Add reference for implementation and add R2HDM

---------

Co-authored-by: Lisa Biermann <[email protected]>
Co-authored-by: Lisa Biermann <[email protected]>
@lisabiermann
Rename tmp in a meaningful way
3bd4f9d
@lisabiermann
Merge branch 'develop' into highT_validity_check
6aa71c9
@vollous vollous changed the title BSMPT v3.0.7 pull request BSMPT v3.0.8 pull request Dec 11, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 13, 2024
View reviewed changes
src/transition_tracer/transition_tracer.cpp
@@ -138,6 +138,9 @@
new_transition_data.crit_false_vev =
pair.false_phase.Get(pair.crit_temp).point;

auto max_ratio = CheckMassRatio(

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable max_ratio is not used.
src/transition_tracer/transition_tracer.cpp
@@ -172,6 +175,11 @@
.Get(new_transition_data.nucl_approx_temp.value_or(
EmptyValue))
.point;

auto max_ratio =

Check notice

Code scanning / CodeQL

Declaration hides variable Note

Variable max_ratio hides another variable of the same name (on
line 141
Loading
).
src/transition_tracer/transition_tracer.cpp
@@ -172,6 +175,11 @@
.Get(new_transition_data.nucl_approx_temp.value_or(
EmptyValue))
.point;

auto max_ratio =

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable max_ratio is not used.
src/transition_tracer/transition_tracer.cpp
@@ -195,6 +203,11 @@
pair.false_phase
.Get(new_transition_data.nucl_temp.value_or(EmptyValue))
.point;

auto max_ratio =

Check notice

Code scanning / CodeQL

Declaration hides variable Note

Variable max_ratio hides another variable of the same name (on
line 141
Loading
).
src/transition_tracer/transition_tracer.cpp
@@ -195,6 +203,11 @@
pair.false_phase
.Get(new_transition_data.nucl_temp.value_or(EmptyValue))
.point;

auto max_ratio =

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable max_ratio is not used.
src/transition_tracer/transition_tracer.cpp
@@ -218,6 +231,11 @@
pair.false_phase
.Get(new_transition_data.perc_temp.value_or(EmptyValue))
.point;

auto max_ratio =

Check notice

Code scanning / CodeQL

Declaration hides variable Note

Variable max_ratio hides another variable of the same name (on
line 141
Loading
).
src/transition_tracer/transition_tracer.cpp
@@ -218,6 +231,11 @@
pair.false_phase
.Get(new_transition_data.perc_temp.value_or(EmptyValue))
.point;

auto max_ratio =

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable max_ratio is not used.
src/transition_tracer/transition_tracer.cpp
@@ -243,6 +261,11 @@
.Get(
new_transition_data.compl_temp.value_or(EmptyValue))
.point;

auto max_ratio =

Check notice

Code scanning / CodeQL

Declaration hides variable Note

Variable max_ratio hides another variable of the same name (on
line 141
Loading
).
src/transition_tracer/transition_tracer.cpp
@@ -243,6 +261,11 @@
.Get(
new_transition_data.compl_temp.value_or(EmptyValue))
.point;

auto max_ratio =

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable max_ratio is not used.
tests/unittests/Test-gw.cpp
@@ -683,6 +683,58 @@
REQUIRE(vac.PhasesList.size() == 2);
}

TEST_CASE("Check maximal thermal mass squared over temperature ratio")

Check notice

Code scanning / CodeQL

Unused static function Note test

Static function CATCH2_INTERNAL_TEST_52 is unreachable (
autoRegistrar53
Loading
must be removed at the same time)
vollous and others added 3 commits December 19, 2024 17:17
@vollous @phbasler @dependabot
Update develop branch (#190)
52326c8 
* Dont try to autocommit on dependabot or fork jobs (#187)

* Dont use secret in dependabot job

* add brackets

* trigger change

* Automatically applied linter

* print env

* add brackets

* Automatically applied linter

* remove debug line

---------

Co-authored-by: GitHub Actions Bot <>

* Next attempt at fixing linter for non local (#188)

* Next attempt at fixing linter for non local

* Update linter.yml

* Update .github/workflows/linter.yml

* Update .github/workflows/linter.yml

* Bump JamesIves/github-pages-deploy-action from 4.6.9 to 4.7.2 (#186)

* Bump JamesIves/github-pages-deploy-action from 4.6.9 to 4.7.2

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.9 to 4.7.2.
- [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases)
- [Commits](JamesIves/github-pages-deploy-action@v4.6.9...v4.7.2)

---
updated-dependencies:
- dependency-name: JamesIves/github-pages-deploy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Next attempt at fixing linter for non local

* Update linter.yml

* Update linter.yml

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Philipp Basler <[email protected]>

* Remove test for ubuntu 20.04 (#189)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Philipp Basler <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@vollous
Merge branch 'master' into develop
8f5d454
@vollous @phbasler
155 fix dependency loop between models and minimizer (#183)
26500e5 
* Objective

* Automated commit of cmake-format changes.

* Fix

* Automated commit of cmake-format changes.

* modelPointer is no longer passed as a pointer

* Check CheckImplementation

* Automatically applied linter

* Missing lib

* add a check that the unit test does check the result text for the pass substring

---------

Co-authored-by: vollous <[email protected]>
Co-authored-by: Philipp Basler <[email protected]>
Co-authored-by: GitHub Actions Bot <>
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 25, 2024
View reviewed changes
src/models/modeltests/ModelTestfunctions.cpp
@@ -1045,5 +1045,178 @@
return TestResults::Pass;
}

void CheckImplementation(const Class_Potential_Origin &point,

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 172 lines.
tests/unittests/Test-origin.cpp
@@ -119,3 +121,24 @@
REQUIRE(result == Approx(expected).margin(1e-4));
}
}

TEST_CASE("Check CheckImplementation", "[origin]")

Check notice

Code scanning / CodeQL

Unused static function Note test

Static function CATCH2_INTERNAL_TEST_4 is unreachable (
autoRegistrar5
Loading
must be removed at the same time)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phbasler phbasler Awaiting requested review from phbasler phbasler will be requested when the pull request is marked ready for review phbasler is a code owner

@lisabiermann lisabiermann Awaiting requested review from lisabiermann lisabiermann will be requested when the pull request is marked ready for review lisabiermann is a code owner

@JonasMueller1991 JonasMueller1991 Awaiting requested review from JonasMueller1991 JonasMueller1991 will be requested when the pull request is marked ready for review JonasMueller1991 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vollous @lisabiermann