Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfriendly link preview for "Consistency in TMTOWTDI Perl" #192

Open
rsindlin opened this issue Apr 17, 2019 · 6 comments
Open

Unfriendly link preview for "Consistency in TMTOWTDI Perl" #192

rsindlin opened this issue Apr 17, 2019 · 6 comments
Assignees
@dnmfarrell
Labels
community: help wanted

Comments

@rsindlin
Copy link

When I paste a link into Outlook, it creates a link preview. For "Consistency in TMTOWTDI Perl", the link preview has an anonymous silhouette for the thumbnail (which also what shows under "Latest articles"... so maybe that's intentional). Worse,though, the preview text is only the Legal spiel:

Legal. Perl.com and the authors make no representations with respect to the accuracy or completeness of the contents of all work on this website and specifically disclaim all warranties, including without limitation warranties of fitness for a particular purpose.
www.perl.com

Other links (eg, "What's new on CPAN - March 2019") have the blurb seen under "Latest Articles" prepended to the Legal statement.

Taken together, the anonymous silhouette and legal statement really make the link preview very unfriendly. Personally, I think I'd rather see either a camel or an onion as the thumbnail instead of a silhouette, but the key to me is that the synopsis isn't showing up in the link preview.

Since it's a relatively new article, one would hope it might be getting shared around, so it seems like it might be worth addressing it.
@dnmfarrell
Copy link
Contributor

Thanks for reporting this. We define preview cards for facebook and twitter. It sounds like we need to do the same for Outlook.

@dnmfarrell
Copy link
Contributor

Three articles, 3 different previews:

https://www.perl.com/article/what-s-new-on-cpan-august-2019/
This is the article metadata concatenated with the first paragraph:
Screenshot from 2019-09-11 13-24-58

https://www.perl.com/article/consistency-in-tmtowtdi-perl/
This is the legal footer:
Screenshot from 2019-09-11 13-24-43

https://www.perl.com/article/how-do-i-open-this-/
This is a subheading and paragraph from midway into the article
Screenshot from 2019-09-11 13-24-29

@dnmfarrell
Copy link
Contributor

I see a couple of bugs in our open graph markup:

  1. We're not providing the mandatory og:type property
  2. The image we link to is the big article image instead of the thumbnail version

It's not incorrect but it might be better to put the google analytics <script> at the end of the <head> so we don't have the metadata tags either side of it. I can fix these issues and try the Outlook preview link again.

@dnmfarrell dnmfarrell self-assigned this Sep 11, 2019
@dnmfarrell
Copy link
Contributor

Also we have og:site name instead of og:site_name

dnmfarrell added a commit that referenced this issue Sep 11, 2019
@dnmfarrell
Use the article thumbnail in the og:image property
a859b91 
It's a smaller image which should make for faster link previews.

issue #192
dnmfarrell added a commit that referenced this issue Sep 11, 2019
@dnmfarrell
Place all metadata tags together
3b9b285 
This *might* help with link previews.

issue #192
dnmfarrell added a commit that referenced this issue Sep 11, 2019
@dnmfarrell
The property name should be "og:site_name"
3b52c2b 
issue #192
dnmfarrell added a commit that referenced this issue Sep 11, 2019
@dnmfarrell
Include the og:type property - it's mandatory
6750659 
Use "article" for articles and "website" for the other pages.

issue #192
dnmfarrell added a commit that referenced this issue Sep 11, 2019
@dnmfarrell
Only check for tags if it's an article
d9f814f 
issue #192
dnmfarrell added a commit that referenced this issue Sep 11, 2019
@dnmfarrell
Only articles have the published_time property
dbe0069 
issue #192
@dnmfarrell
Copy link
Contributor

I found a few more bugs in the og markup. Once the site has re-deployed I'll test again.

@dnmfarrell
Copy link
Contributor

OWA shows the same link previews as before, I'm not sure if the changes have not fixed the issue, or if MS cache the previews and they need to be cleared first. @rsindlin any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnmfarrell dnmfarrell

Labels
community: help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnmfarrell @rsindlin