-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for boxes_flow, allow None #396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this beautifull small improvement. It is these things that will make it a pleasure to work with pdfminer.six.
I've added a bunch of minor requests.
36ce049
to
20bf807
Compare
@pietermarsman Thanks for the review - all makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge it tonight.
If you have time: i've 2 tiny suggestions
I've just noticed there are a few other places that the documentation needs updating - don't merge until I've fixed that :) |
Okay, now this should be good 👍 |
Wow: one of the tests failed because apparently tox doesn't work with python 3.4 anymore. In this PR we can solve it by specifying an older version of tox. I'll see if we can drop support for python 3.4 in the future. |
Agree, except I think this project depends on This installed the latest version of tox, which is v3.14.6. Tox deprecated Python 3.4 in v3.14.1, but the deprecation says it won't actually get removed until the next major release. (tox changelog) I don't think specifying a specific version of That said, I agree dropping python 3.4 support is a good idea. |
Okay, that worked - tests are now green ✔️ |
Pull request
Closes #395
Allows passing
boxes_flow
asNone
to disable the advanced layout analysisUpdates the documentation to this effect (if you want me to call it something other than "advanced layout analysis - let me know!)
I've added a private
__validate
method toLAParams
to check that boxes flow is eitherNone
, or between-1
and+1
. Happy to remove this if you think it's excessive..I've NOT added any other checks about any other params to
__validate
. I'm happy to do this, but there don't seem to be any other specified ranges in the docs, so I'd just be checking the types, really.How Has This Been Tested?
I checked before the change that passing
None
breaks, and after that it works (usingextract_pages
). The speed changes a lot without the extra layout analysis, so I could tell it was working.tox
passes.Checklist
works
version
is not necessary
verified that this is not necessary
CHANGELOG.md