-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add admin.hidden to collections and globals #2487
Conversation
As I think about this more, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub shit the bed on this diff. The only line really changed here is the .filter()
added at L180 and the rest is spacing.
Thanks a lot for this! It almost went unnoticed for me, but this pretty much solves #1462 Should I close the discussion and link this PR as solution? |
This feature is exactly what I was in need for just now. Just upgraded and tested it out. I noticed I am not getting the full user object however which makes it unusable for making the collection hidden based on the role. I am getting this data atm:
Is this the intended return object or is this a bug @DanRibbens ? |
Hi @philipgher! To add more properties to this object you can add I do agree it would be nicer to have the full user object passed through |
Ahh right that makes sense once you know it. Thanks for explaining this @DanRibbens. By reading through the changes in this PR I did notice the data indirectly came from the Maybe a documentation update would suffice here. Maybe getting the full user object would be nice if there's no (acceptable) performance hit or something like that. |
Description
Allows configuation of collections and globals to be excluded from the admin UI in navigation and routing using
admin.hidden
.Type of change
Checklist: