Attempt to fix from_str overflow rounding
#454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-cantor
force-pushed
the
issue/453
branch
2 times, most recently
from
0bb52d3 to
9c51e7d
Compare
added 2 commits
December 29, 2021 22:11
cargo bench --bench lib_benches -- decimal_from_str Baseline: test decimal_from_str ... bench: 566 ns/iter (+/- 21) Current: test decimal_from_str ... bench: 290 ns/iter (+/- 12)
cargo bench --bench lib_benches -- decimal_from_str Baseline: test decimal_from_str ... bench: 566 ns/iter (+/- 21) Current: test decimal_from_str ... bench: 193 ns/iter (+/- 1)
chris-cantor
force-pushed
the
issue/453
branch
from
9c51e7d to
7289df8
Compare
|
I tried to remove the coeff Here is the relevant bench on my M1 Pro: All checks seem to pass now https://github.com/cantortrading/rust-decimal/actions/runs/1634285353 |
|
Closed in favour of #455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #453
The culprit is the rounding behaviour prevented it from overflowing, and ended up returning an
Okin the end. The fix is: we should not attempt to round a number before the decimal point.Having read through the code, I think there are opportunities to make
parse_str_radix_10faster & simpler, e.g. removing the coeffArrayVecand doing it in one pass; using 128 bit integer arithmetic etc.I wonder what is your view on this?