Skip to content

Commit

Permalink
[postmortem] add JS_ERROR_TYPE and context embedder index
Browse files Browse the repository at this point in the history
  * JS_ERROR_TYPE is required for postmortem tools to inspect JSError
    objects (see nodejs/llnode#215 for a usage
    example)
  * The context embedder index is required for postmortem tools to
    access embedder data stored in the context (see
    nodejs/llnode#204 for a usage example)

[email protected], [email protected]

Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25
Reviewed-on: https://chromium-review.googlesource.com/1138493
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#54475}
  • Loading branch information
Matheus Marchini authored and Commit Bot committed Jul 16, 2018
1 parent 02fe0c2 commit 804a693
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions tools/gen-postmortem-metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,9 @@
'value': 'Context::EXTENSION_INDEX' },
{ 'name': 'context_min_slots',
'value': 'Context::MIN_CONTEXT_SLOTS' },
{ 'name': 'context_idx_embedder_data',
'value': 'Internals::kContextEmbedderDataIndex' },


{ 'name': 'namedictionaryshape_prefix_size',
'value': 'NameDictionaryShape::kPrefixSize' },
Expand All @@ -224,6 +227,8 @@
'value': 'SimpleNumberDictionaryShape::kPrefixSize' },
{ 'name': 'simplenumberdictionaryshape_entry_size',
'value': 'SimpleNumberDictionaryShape::kEntrySize' },

{ 'name': 'type_JSError__JS_ERROR_TYPE', 'value': 'JS_ERROR_TYPE' },
];

#
Expand Down

0 comments on commit 804a693

Please sign in to comment.