Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tree): use MultiProofTargets for PrefetchProofs #13717

Merged
merged 2 commits into from
Jan 9, 2025
Merged

chore(tree): use MultiProofTargets for PrefetchProofs #13717

merged 2 commits into from
Jan 9, 2025
+5 −7

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jan 7, 2025 •
edited
Loading

ref #13713

This uses MultiProofTargets in the PrefetchProofs enum variant now.

@Rjected Rjected added C-enhancement New feature or request A-trie Related to Merkle Patricia Trie implementation labels Jan 7, 2025
@Rjected Rjected force-pushed the dan/add-storage-to-prefetchproofs branch from c41536a to c144aa1 Compare January 7, 2025 22:54
@Rjected Rjected mentioned this pull request Jan 8, 2025
Open
rkrasiuk
rkrasiuk requested changes Jan 8, 2025
View reviewed changes
crates/engine/tree/src/tree/root.rs Outdated Show resolved Hide resolved
@Rjected Rjected requested a review from rkrasiuk January 8, 2025 16:16
@Rjected Rjected force-pushed the dan/add-storage-to-prefetchproofs branch from 15aa96f to 8e70ee7 Compare January 9, 2025 20:10
@Rjected Rjected changed the title chore(tree): add ProofTarget enum to PrefetchProofs chore(tree): use MultiProofTargets for PrefetchProofs Jan 9, 2025
@Rjected
Copy link
Member Author

Rjected commented Jan 9, 2025

cc @shekhirin @rkrasiuk this is now now using MultiProofTargets

@Rjected Rjected added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 986c754 Jan 9, 2025
43 checks passed
@Rjected Rjected deleted the dan/add-storage-to-prefetchproofs branch January 9, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin left review comments

@DaniPopes DaniPopes DaniPopes approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rjected @shekhirin @rkrasiuk @DaniPopes