DEPR: remove deprecated verbose, private_key kwargs for gbq #30200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to modify these tests too: > test_read_gbq_with_deprecated_kwargs |
|
removed test, added a whatsnew note that didnt make it into #30199 |
tswast
approved these changes
Dec 11, 2019
| @@ -534,6 +534,7 @@ or ``matplotlib.Axes.plot``. See :ref:`plotting.formatters` for more. | |||
| - :meth:`Series.plot` no longer accepts positional arguments, pass keyword arguments instead (:issue:`30003`) | |||
| - :meth:`DataFrame.hist` and :meth:`Series.hist` no longer allows ``figsize="default"``, specify figure size by passinig a tuple instead (:issue:`30003`) | |||
| - Floordiv of integer-dtyped array by :class:`Timedelta` now raises ``TypeError`` (:issue:`21036`) | |||
| - :class:`TimedeltaIndex` and :class:`DatetimeIndex` no longer accept non-nanosecond dtype strings like "timedelta64" or "datetime64", use "timedelta64[ns]" and "datetime64[ns]" instead (:issue:`24806`) | |||
There was a problem hiding this comment.
Doesn't seem related to this change.
There was a problem hiding this comment.
correct, see comment #30200 (comment)
|
IIRC I remember seeing something about |
|
That's right. I filed googleapis/python-bigquery-pandas#301 to actually remove it. I'll do that and cut a pandas-gbq release today. |
|
so should i revert the private_key change here? warn? |
|
It's okay to remove. We've been showing a warning since we deprecated it in pandas 0.24.0. Soon it'll hard fail if it's ever supplied. |
WillAyd
reviewed
Dec 12, 2019
|
Thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
This was referenced Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation didn't have a whatsnew note or actually use deprecate_kwarg, so im not sure how formal the removal should be.
xref #20564.