This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
rename TransactionKeyValueService to DataKeyValueService #7307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
👋 I'll get some time for this tomorrow! |
jeremyk-91
approved these changes
Oct 4, 2024
| @@ -59,8 +59,7 @@ public class GetRowsColumnRangeIteratorTest { | |||
| public static final BatchColumnRangeSelection COLUMN_RANGE_SELECTION = | |||
| BatchColumnRangeSelection.create(null, null, BATCH_SIZE); | |||
|
|
|||
| private final TransactionKeyValueService tkvs = | |||
| new DelegatingTransactionKeyValueService(new InMemoryKeyValueService(true)); | |||
| private final DataKeyValueService tkvs = new DelegatingDataKeyValueService(new InMemoryKeyValueService(true)); | |||
There was a problem hiding this comment.
nit: let's rename the variable to dkvs?
| @@ -73,14 +73,14 @@ public static List<Integer> sizes() { | |||
| private RangeRequest rangeRequest; | |||
|
|
|||
| @Mock | |||
| private TransactionKeyValueService tkvs; | |||
| private DataKeyValueService tkvs; | |||
There was a problem hiding this comment.
yeah this one should be dkvs too
| throws InterruptedException; | ||
| } | ||
|
|
||
| private Expectations asyncGetExpectation( | ||
| TransactionKeyValueService tkvMock, Cell cell, long transactionTs, LockService lockMock) { | ||
| DataKeyValueService tkvMock, Cell cell, long transactionTs, LockService lockMock) { |
|
Released 0.1162.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Before this PR:
The name "TransactionKeyValueService" was chosen represent the key value interface available within transactions. After some discussion, we determined that this name was confusing, as it is the interface used to operate on data tables, not on the Transactions tables.
After this PR:
DataKeyValueService is a better name, because from the perspective of configuration, the data KVS is responsible for storing the data tables.
This API is currently marked as beta, and there are no production usages at this time, so this rename is safe to do.
==COMMIT_MSG==
rename TransactionKeyValueService to DataKeyValueService
==COMMIT_MSG==
Please tag any other people who should be aware of this PR:
@jeremyk-91