This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Retry on hosts in different datacenters #5902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
Jolyon-S
reviewed
Feb 10, 2022
...b-cassandra/src/main/java/com/palantir/atlasdb/keyvalue/cassandra/pool/CassandraService.java
Outdated
Show resolved
Hide resolved
Comment on lines
172
to
182
| config.servers().accept(new CassandraServersConfigs.ThriftHostsExtractingVisitor()); | ||
| config.servers().accept(new ThriftHostsExtractingVisitor()); |
leonz
reviewed
Feb 10, 2022
| .mapKeys(EndpointDetails::getHost) | ||
| .mapKeys(this::getAddressForHostThrowUnchecked) | ||
| .map(EndpointDetails::getDatacenter) | ||
| .collectToMap(); |
There was a problem hiding this comment.
please trace log this so we can more easily reason about it if needed
There was a problem hiding this comment.
discussed offline: moved to once per iteration as opposed to once per interval, but added!
Jolyon-S
reviewed
Feb 10, 2022
...b-cassandra/src/main/java/com/palantir/atlasdb/keyvalue/cassandra/pool/CassandraService.java
Show resolved
Hide resolved
Comment on lines
169
to
189
| public void selectsAnyHostIfAllDatacentersAlreadyTried() { | ||
| ImmutableSet<InetSocketAddress> allHosts = ImmutableSet.of(HOST_1, HOST_2); | ||
| CassandraService cassandra = clientPoolWithServers(allHosts); | ||
| cassandra.overrideHostToDatacenterMapping(ImmutableMap.of(HOST_1, DC_1, HOST_2, DC_2)); | ||
| Set<InetSocketAddress> suggestedHosts = IntStream.range(0, 1_000) | ||
| .mapToObj(attempt -> cassandra.getRandomGoodHostForPredicate(address -> true, allHosts)) | ||
| .flatMap(Optional::stream) | ||
| .map(CassandraClientPoolingContainer::getHost) | ||
| .collect(Collectors.toSet()); | ||
| assertThat(suggestedHosts).containsExactlyInAnyOrderElementsOf(allHosts); | ||
| } | ||
|
|
||
| @Test | ||
| public void selectsAnyHostIfNoDatacentersAlreadyTried() { | ||
| ImmutableSet<InetSocketAddress> allHosts = ImmutableSet.of(HOST_1, HOST_2); | ||
| CassandraService cassandra = clientPoolWithServers(allHosts); | ||
| cassandra.overrideHostToDatacenterMapping(ImmutableMap.of(HOST_1, DC_1, HOST_2, DC_2)); | ||
| Set<InetSocketAddress> suggestedHosts = IntStream.range(0, 1_000) | ||
| .mapToObj(attempt -> cassandra.getRandomGoodHostForPredicate(address -> true, ImmutableSet.of())) | ||
| .flatMap(Optional::stream) | ||
| .map(CassandraClientPoolingContainer::getHost) |
There was a problem hiding this comment.
it'd be great if we could extract a common method here
|
|
||
| @Test | ||
| public void selectsHostMatchingPredicateEvenIfRelatedHostsAlreadyTried() { | ||
| ImmutableSet<InetSocketAddress> allHosts = ImmutableSet.of(HOST_1, HOST_2, HOST_3); |
There was a problem hiding this comment.
we don't need this variable when we only use it once
|
|
||
| @Test | ||
| public void selectsHostsWithUnknownDatacenterMappingIfAllKnownDatacentersTried() { | ||
| ImmutableSet<InetSocketAddress> allHosts = ImmutableSet.of(HOST_1, HOST_2, HOST_3); |
|
👍 |
|
Released 0.540.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
==COMMIT_MSG==
==COMMIT_MSG==
Implementation Description (bullets):
Testing (What was existing testing like? What have you done to improve it?):
Concerns (what feedback would you like?):
Where should we start reviewing?:
Priority (whenever / two weeks / yesterday):