Fix ingress thread deadlock for resubmit packets #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resubmit packets were written to the input_buffer with a blocking call by the ingress thread. Since the ingress thread is also in charge of draining the input_buffer, this could have lead to a deadlock. Resubmit packets can now be dropped if the buffer is full. To limit the number of resubmit packets being lost, we place them is a higher priority queue than "normal" packets. Fixes #729
antoninbas
force-pushed
the
antonin/simple-switch-fix-ingress-thread-deadlock-for-resubmit-packets
branch
from
e373de4 to
1e650aa
Compare
jafingerhut
reviewed
Mar 7, 2019
| //! As for QueueingLogicRL, the write behavior (push_front()) is blocking: once | ||
| //! a logical queue is full, subsequent incoming elements will be dropped until | ||
| //! the queue starts draining again. | ||
| //! As for QueueingLogicRL, the write behavior (push_front()) is not blocking: |
There was a problem hiding this comment.
Sorry, I do not know the BMv2 internals very well at all, so just throwing up a random red flag on comment changes -- After your changes is the phrase "As for QueueingLogicRL" still correct?
There was a problem hiding this comment.
I didn't change anything in this file. I realized this comment was not correct so I fixed it, but it has nothing to do with the rest of the changes.
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
==========================================
+ Coverage 74.45% 74.46% +0.01%
==========================================
Files 115 115
Lines 9970 9970
==========================================
+ Hits 7423 7424 +1
+ Misses 2547 2546 -1
Continue to review full report at Codecov.
|
antoninbas
deleted the
antonin/simple-switch-fix-ingress-thread-deadlock-for-resubmit-packets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmit packets were written to the input_buffer with a blocking call
by the ingress thread. Since the ingress thread is also in charge of
draining the input_buffer, this could have lead to a deadlock. Resubmit
packets can now be dropped if the buffer is full. To limit the number of
resubmit packets being lost, we place them is a higher priority queue
than "normal" packets.
Fixes #729