Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Powershell and vale linters to cupcake flavor #4481

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Jan 10, 2025

Fixes #4364

@bdovaz
Copy link
Collaborator Author

bdovaz commented Jan 10, 2025

/build

Command run output
Build command workflow started.
Installing dependencies
Running script ./build.sh
Build command workflow completed updating files.

Copy link
Contributor

github-actions bot commented Jan 10, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ API spectral 1 0 1.79s
⚠️ BASH bash-exec 6 1 0.04s
✅ BASH shellcheck 6 0 0.21s
✅ BASH shfmt 6 0 0 1.01s
✅ COPYPASTE jscpd yes no 3.58s
✅ DOCKERFILE hadolint 129 0 23.92s
✅ JSON jsonlint 20 0 0.25s
✅ JSON v8r 22 0 15.09s
⚠️ MARKDOWN markdownlint 267 0 301 28.17s
✅ MARKDOWN markdown-table-formatter 267 0 0 168.26s
⚠️ PYTHON bandit 214 66 3.02s
✅ PYTHON black 214 0 0 4.99s
✅ PYTHON flake8 214 0 2.22s
✅ PYTHON isort 214 0 0 1.28s
✅ PYTHON mypy 214 0 15.87s
✅ PYTHON pylint 214 0 34.69s
✅ PYTHON ruff 214 0 0 0.49s
✅ REPOSITORY checkov yes no 36.86s
✅ REPOSITORY git_diff yes no 0.72s
⚠️ REPOSITORY grype yes 26 13.17s
✅ REPOSITORY secretlint yes no 10.43s
✅ REPOSITORY trivy yes no 15.12s
✅ REPOSITORY trivy-sbom yes no 0.29s
⚠️ REPOSITORY trufflehog yes 1 54.33s
✅ SPELL cspell 717 0 13.65s
⚠️ SPELL lychee 349 14 5.15s
✅ XML xmllint 3 0 0 0.78s
✅ YAML prettier 160 0 0 5.3s
✅ YAML v8r 102 0 32.46s
✅ YAML yamllint 161 0 2.95s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator

echoix commented Jan 10, 2025

What's the size increase with that? We wouldn't want to make the cupcake to be like the full

@bdovaz
Copy link
Collaborator Author

bdovaz commented Jan 10, 2025

What's the size increase with that? We wouldn't want to make the cupcake to be like the full

How can I check it in the most realistic way possible? I have run over the repository:

docker buildx build -f ./flavors/cupcake/Dockerfile . --tag cupcake

But the result does not make sense:

REPOSITORY TAG IMAGE ID CREATED SIZE
cupcake latest 3d504cdb0c86 49 seconds ago 6.1GB

@echoix
Copy link
Collaborator

echoix commented Jan 10, 2025

I think we're at 10 for the full, isn't it that?

@echoix
Copy link
Collaborator

echoix commented Jan 10, 2025

There's the compressed and uncompressed size too

@bdovaz
Copy link
Collaborator Author

bdovaz commented Jan 10, 2025

There's the compressed and uncompressed size too

But how do I see that? With docker images I only see one value

@echoix
Copy link
Collaborator

echoix commented Jan 10, 2025

There's the compressed and uncompressed size too

But how do I see that? With docker images I only see one value

It seems docker images gives uncompressed, and the compressed size can be checked in the registry or other ways https://www.back2code.me/2020/10/docker-images-size/

https://gist.github.com/MichaelSimons/fb588539dcefd9b5fdf45ba04c302db6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flavor cupcake is missing several linters
2 participants