-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base image to 3.12.1-alpine3.19 #3266
Conversation
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ BASH | bash-exec | 5 | 0 | 0.16s | |
✅ BASH | shellcheck | 5 | 0 | 0.21s | |
✅ BASH | shfmt | 5 | 0 | 0 | 0.55s |
✅ COPYPASTE | jscpd | yes | no | 4.65s | |
✅ DOCKERFILE | hadolint | 127 | 0 | 19.68s | |
✅ JSON | eslint-plugin-jsonc | 23 | 0 | 0 | 3.61s |
✅ JSON | jsonlint | 21 | 0 | 0.27s | |
✅ JSON | v8r | 23 | 0 | 20.1s | |
✅ MAKEFILE | checkmake | 1 | 0 | 0.01s | |
markdownlint | 261 | 0 | 262 | 30.52s | |
✅ MARKDOWN | markdown-link-check | 261 | 0 | 9.19s | |
✅ MARKDOWN | markdown-table-formatter | 261 | 0 | 0 | 138.04s |
✅ OPENAPI | spectral | 1 | 0 | 1.81s | |
bandit | 208 | 64 | 4.03s | ||
✅ PYTHON | black | 208 | 0 | 0 | 5.34s |
✅ PYTHON | flake8 | 208 | 0 | 2.58s | |
✅ PYTHON | isort | 208 | 0 | 0 | 1.23s |
✅ PYTHON | mypy | 208 | 0 | 16.26s | |
✅ PYTHON | pylint | 208 | 0 | 16.95s | |
pyright | 208 | 352 | 27.76s | ||
✅ PYTHON | ruff | 208 | 0 | 0 | 0.62s |
✅ REPOSITORY | checkov | yes | no | 42.36s | |
✅ REPOSITORY | git_diff | yes | no | 0.55s | |
grype | yes | 1 | 24.1s | ||
✅ REPOSITORY | secretlint | yes | no | 12.36s | |
✅ REPOSITORY | trivy | yes | no | 27.32s | |
✅ REPOSITORY | trivy-sbom | yes | no | 9.79s | |
trufflehog | yes | 1 | 21.81s | ||
✅ SPELL | cspell | 683 | 0 | 30.05s | |
✅ SPELL | lychee | 341 | 0 | 3.45s | |
✅ XML | xmllint | 3 | 0 | 0 | 0.51s |
✅ YAML | prettier | 160 | 0 | 0 | 7.19s |
✅ YAML | v8r | 102 | 0 | 169.56s | |
✅ YAML | yamllint | 161 | 0 | 2.34s |
See detailed report in MegaLinter reports
You changed revive and the base image in this PR? |
The change of revive is because I was getting an error that I thought that maybe leaving the previous installation method (the one that was commented) was going to fix it. I don't know either but it seems that the revive error is caused by Alpine 3.19. Do you know @echoix what is happening? |
Nope, I don't know (yet). But alpine 3.19 changes the go version, but it should have been built with a higher version anyways because of the very loose tag on the building image. The revive in the docker image they provide still didn't include the version number last time I tried. |
@echoix the revive problem is recent, it is from the release of a few days ago (1.3.5): mgechev/revive#956 I just encountered that problem and I thought it was because of the Alpine version. I have downgraded to 1.3.4 for now. |
Now it only fails: https://github.com/oxsecurity/megalinter/actions/runs/7423769467/job/20204128689?pr=3266 Specifically, this linter: https://megalinter.io/latest/descriptors/clojure_cljstyle/ Do you know what it could be? |
Can you test like locally a dockerfile that installs cljstyle only, like the one used in the smaller image, and add a call to the linter help and version, see if 1) if launches, and 2) what the version is (to know if it is the regex that is bad). |
@echoix leaving the entrypoint.sh file with: #!/usr/bin/env bash
/usr/local/bin/cljstyle version With Alpine 3.18:
With Alpine 3.19:
Any way to debug the Segmentation fault? I also see that although in the last month there has been some activity, the reality is that the project has been stopped for 2 years, the last release is from 2021 (I do not know if it may have to do with some kind of incompatibility in recent versions of Alpine): |
Segfaults are real "bugs". Like invalid memory accesses by the program, or serious errors. The binary is not compatible as is. Is there a way to recompile, or have a newer binary (from the same sources, but needs to be recompiled at some point for sure) |
there is still an issue with lychee new version, I investigate and try to fix that in main |
There is no alpine based lychee docker image for their previous version.... i check if I find another way :/ |
@nvuillam ready? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @bdovaz :)
https://hub.docker.com/_/python/tags?page=1&name=alpine3.19
There is the tag
3.12-alpine3.19
but I understand that seeing the value that was set we want a certain determinism, right @nvuillam?