TEMPLATES/mega-linter.yml: DRY the ifs

[rasa]

Proposed Changes

This simplifies TEMPLATES/mega-linter.yml by moving common code to its own step. This also can help with debugging, as these variables now show up in the logs. Accept or reject as you see fit.

Readiness Checklist

Edit: I've had success running this PR in private repos.

Author/Contributor

• Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
• If documentation is needed for this change, has that been included in this pull request

[nvuillam]

@rasa it seems an interesting PR :)
Did you test it and do you confirm the behavior is exactly the same ? I wouldn't like to take the risk of regressions ^^

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

[rasa]

Did you test it and do you confirm the behavior is exactly the same ? I wouldn't like to take the risk of regressions ^^

I have tested it locally, and both code paths work as intended. Unfortunately, I can't share logs as they are on private repos.

But since it's just DRYing the code, feel free to reject. I won't take offense.

[nvuillam]

@rasa I love DRY rules, so if you tested it let's trust you and see how it goes on own MegaLinter :)

But to do that, please can you also update own MegaLinter workflows ?

• .github/workflows/mega-linter.yml
• .github/workflows/mega-linter-for-runner.yml

[nvuillam]

@rasa seems good but you need to merge main in your branch to solve conflicts before i can validate :)

[nvuillam]

Wonderful:)
Many thanks for your contribution @rasa 🎉

[nvuillam]

@rasa please can you also make a PR to update https://github.com/oxsecurity/megalinter/blob/main/mega-linter-runner/generators/mega-linter/templates/mega-linter.yml ?

This is the file that is used by the installer ^^