Use local properties when querying oxide values #6988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Oxide-specific ZFS properties to attach additional metadata to datasets, such as UUIDs.
Unfortunately, by default, when we query these properties, the information is inherited.
This means that, for example, if we try to set the "oxide:uuid" property on a transient zone filesystem root, say,
And we have a dataset within that existing dataset which does not have the "oxide:uuid" property set, at, say:
Then when we query
zfs get oxide:uuid
on each of these datasets, we'll see the UUID of the transient root for both datasets.By using the
-s local
argument to ZFS get, we prevent this from happening - now, these properties will only be accessible for the dataset where they are directly set.