refactor: create path params types module, rename current path params to "selectors" #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
cleanup-params
branch
from
4cddb55 to
87a53c7
Compare
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 6, 2024
oxidecomputer/console@fd47bee...927c8b6 * [927c8b63](oxidecomputer/console@927c8b63) oxidecomputer/console#2608 * [01a0ac99](oxidecomputer/console@01a0ac99) oxidecomputer/console#2597 * [243c55d7](oxidecomputer/console@243c55d7) oxidecomputer/console#2606 * [deb5e187](oxidecomputer/console@deb5e187) oxidecomputer/console#2603 * [67633aac](oxidecomputer/console@67633aac) oxidecomputer/console#2601 * [6405e0cb](oxidecomputer/console@6405e0cb) oxidecomputer/console#2605 * [8c37bad2](oxidecomputer/console@8c37bad2) oxidecomputer/console#2602 * [081599c3](oxidecomputer/console@081599c3) oxidecomputer/console#2599
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 6, 2024
oxidecomputer/console@fd47bee...927c8b6 * [927c8b63](oxidecomputer/console@927c8b63) oxidecomputer/console#2608 * [01a0ac99](oxidecomputer/console@01a0ac99) oxidecomputer/console#2597 * [243c55d7](oxidecomputer/console@243c55d7) oxidecomputer/console#2606 * [deb5e187](oxidecomputer/console@deb5e187) oxidecomputer/console#2603 * [67633aac](oxidecomputer/console@67633aac) oxidecomputer/console#2601 * [6405e0cb](oxidecomputer/console@6405e0cb) oxidecomputer/console#2605 * [8c37bad2](oxidecomputer/console@8c37bad2) oxidecomputer/console#2602 * [081599c3](oxidecomputer/console@081599c3) oxidecomputer/console#2599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we were calling path params were really API selectors, and we weren't exporting the actual path params (with all fields required) so that we could use them in places. This PR renames the existing PP to Sel and creates a new PP that is the real PP.