Skip to content

Commit

Permalink
fix(flag): remove unnecessary instructions
Browse files Browse the repository at this point in the history
  • Loading branch information
skhamvon authored and dpellier committed Aug 16, 2023
1 parent 5e0ea78 commit f740f78
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
1 change: 0 additions & 1 deletion packages-new/components/flag/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "@ovhcloud/ods-component-flag",
"version": "15.0.1",
"private": true,
"description": "ODS Flag component",
"author": "OVH SAS",
"license": "Apache-2.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ describe('ods-flag-controller', () => {
it('should call load with no url', () => {
setup();
controller.load(true);
// expect(loadContent.load).toHaveBeenCalledTimes(1);
expect(mockLoad).toHaveBeenCalledWith('', true, true, true);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ jest.mock('./core/controller')

import type { SpecPage } from '@stencil/core/testing';
import type { OdsFlagAttribute } from './interfaces/attributes';
import { ODS_COUNTRY_ISO_CODE, OdsComponentAttributes2StringAttributes } from '@ovhcloud/ods-common-core';
import { odsStringAttributes2Str, odsUnitTestAttribute } from '@ovhcloud/ods-common-testing';
import { ODS_COUNTRY_ISO_CODE } from '@ovhcloud/ods-common-core';
import { odsStringAttributes2Str, odsComponentAttributes2StringAttributes, odsUnitTestAttribute } from '@ovhcloud/ods-common-testing';
import { Build } from '@stencil/core';
import { newSpecPage } from '@stencil/core/testing';
import { getAssetPath } from '@stencil/core/internal';
Expand All @@ -21,7 +21,7 @@ describe('spec:osds-flag', () => {
let controller: OdsFlagController;

async function setup({ attributes = {} }: { attributes?: Partial<OdsFlagAttribute> } = {}) {
const stringAttributes = OdsComponentAttributes2StringAttributes<OdsFlagAttribute>({ ...baseAttribute, ...attributes }, DEFAULT_ATTRIBUTE);
const stringAttributes = odsComponentAttributes2StringAttributes<OdsFlagAttribute>({ ...baseAttribute, ...attributes }, DEFAULT_ATTRIBUTE);

page = await newSpecPage({
components: [OsdsFlag],
Expand Down

0 comments on commit f740f78

Please sign in to comment.