fix(phone-number): empty string on odsChange event

Signed-off-by: Alexandre Esteves <[email protected]>
ovh · Nov 28, 2024 · da4a77d · da4a77d
1 parent f6b0f00
commit da4a77d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/...ages/ods/src/components/phone-number/src/components/ods-phone-number/ods-phone-number.tsx b/...ages/ods/src/components/phone-number/src/components/ods-phone-number/ods-phone-number.tsx
@@ -176,7 +176,7 @@ export class OdsPhoneNumber {
   private async onOdsChange(event: OdsInputChangeEvent): Promise<void> {
     event.stopImmediatePropagation();
 
-    this.value = event.detail.value as string ?? null;
+    this.value = event.detail.value as string | null;
 
     if (!isValidPhoneNumber(this.value, this.isoCode, this.phoneUtils)) {
       await this.inputElement?.setCustomValidity(this.customValidityMessage);

diff --git a/packages/ods/src/components/phone-number/src/controller/ods-phone-number.ts b/packages/ods/src/components/phone-number/src/controller/ods-phone-number.ts
@@ -17,6 +17,10 @@ type TranslatedCountryMap = Map<OdsPhoneNumberCountryIsoCode, { isoCode: OdsPhon
 const VALUE_DEFAULT_VALUE = null;
 
 function formatPhoneNumber(value: string | null, isoCode: OdsPhoneNumberCountryIsoCode | undefined, phoneUtils: PhoneNumberUtil): string | null {
+  if (value === '') {
+    return '';
+  }
+
   const phoneNumber = parsePhoneNumber(value, isoCode, phoneUtils);
 
   if (!phoneNumber) {

diff --git a/packages/ods/src/components/phone-number/tests/behaviour/ods-phone-number.e2e.ts b/packages/ods/src/components/phone-number/tests/behaviour/ods-phone-number.e2e.ts
@@ -81,7 +81,7 @@ describe('ods-phone-number behaviour', () => {
           isoCode: 'fr',
           previousValue: null,
           validity: {},
-          value: null,
+          value: '',
         });
       });
     });
@@ -95,7 +95,7 @@ describe('ods-phone-number behaviour', () => {
           isoCode: 'fr',
           previousValue: null,
           validity: {},
-          value: null,
+          value: '',
         });
       });
     });