fix(text): restore ternary and add new test for it

ovh · Oct 6, 2023 · bab890c · bab890c
1 parent 2cf2fe7
commit bab890c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/components/text/src/components/osds-text/osds-text.spec.ts b/packages/components/text/src/components/osds-text/osds-text.spec.ts
@@ -46,6 +46,14 @@ describe('spec:osds-text', () => {
     expect(root?.getAttribute('style')).toBe(styleVar);
   });
 
+  it('should not set a style variable', async () => {
+    await setup({ attributes: {
+      color: "",
+      hue: ""
+    } });
+    expect(root?.getAttribute('style')).toBeNull();
+  });
+
   describe('attributes', () => {
     const config = {
       instance: () => instance,

diff --git a/packages/components/text/src/components/osds-text/osds-text.tsx b/packages/components/text/src/components/osds-text/osds-text.tsx
@@ -35,7 +35,7 @@ export class OsdsText implements OdsTextAttribute {
 
   render() {
     return (
-      <Host style={{ '--osds-text-color-specific-hue': `var(${odsGenerateColorVariable(this.color!, this.hue!)})` }}>
+      <Host style={{ '--osds-text-color-specific-hue': this.color && this.hue ? `var(${odsGenerateColorVariable(this.color, this.hue)})` : '' }}>
         <slot></slot>
       </Host>
     );