feat(text): change preset caption tag to span

Signed-off-by: astagnol <[email protected]>
ovh · Nov 13, 2024 · b993eb0 · b993eb0
1 parent 72cf7f3
commit b993eb0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/ods/src/components/text/src/components/ods-text/ods-text.tsx b/packages/ods/src/components/text/src/components/ods-text/ods-text.tsx
@@ -14,7 +14,7 @@ export class OdsText {
       case ODS_TEXT_PRESET.paragraph:
         return 'p';
       case ODS_TEXT_PRESET.caption:
-        return 'caption';
+        return 'span';
       case ODS_TEXT_PRESET.code:
         return 'code';
       case ODS_TEXT_PRESET.span:

diff --git a/packages/ods/src/components/text/tests/rendering/ods-text.e2e.ts b/packages/ods/src/components/text/tests/rendering/ods-text.e2e.ts
@@ -43,7 +43,7 @@ describe('ods-text rendering', () => {
     it('should render with preset caption', async() => {
       await setup('<ods-text preset="caption">some text</ods-text>');
       expect(el.getAttribute('preset')).toBe('caption');
-      expect(part.tagName).toBe('CAPTION');
+      expect(part.tagName).toBe('SPAN');
     });
 
     it('should render with preset code', async() => {

diff --git a/packages/ods/src/components/text/tests/rendering/ods-text.spec.ts b/packages/ods/src/components/text/tests/rendering/ods-text.spec.ts
@@ -38,7 +38,7 @@ describe('ods-text rendering', () => {
       await setup(`<ods-text preset="${presetValue}"></ods-text>`);
 
       expect(part?.classList.contains('ods-text--caption')).toBe(true);
-      expect(part?.tagName).toBe('CAPTION');
+      expect(part?.tagName).toBe('SPAN');
     });
   });
 });