Skip to content

Commit

Permalink
fix(phone-number): value type & remove el
Browse files Browse the repository at this point in the history
  • Loading branch information
aesteves60 authored and dpellier committed Sep 25, 2023
1 parent 0fe9f5c commit b3a4e5d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ interface OdsPhoneNumberAttribute {
/** Indicates if the phone number shows error or not */
error?: boolean;
/** Current value of the phone number */
value: string;
value: string | null;
}

export {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe('spec:osds-phone-number', () => {
name: 'value',
defaultValue: DEFAULT_ATTRIBUTE.value,
newValue: 'new value',
value: 'old value',
value: null,
setup: (value) => setup({ attributes: { value } }),
...config,
});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, Element, Host, h, Prop } from '@stencil/core';
import { Component, Host, h, Prop } from '@stencil/core';
import { ODS_INPUT_TYPE } from '@ovhcloud/ods-component-input';
import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import { OdsPhoneNumberAttribute } from './interfaces/attributes';
Expand All @@ -12,8 +12,6 @@ import { OdsPhoneNumberAttribute } from './interfaces/attributes';
shadow: true
})
export class OsdsPhoneNumber implements OdsPhoneNumberAttribute {
@Element() el!: HTMLElement;

/** @see OdsPhoneNumberAttribute.clearable */
@Prop({ reflect: true }) clearable?: boolean = DEFAULT_ATTRIBUTE.clearable;

Expand Down

0 comments on commit b3a4e5d

Please sign in to comment.