Skip to content

Commit

Permalink
fix(doc): use correct badge + typo
Browse files Browse the repository at this point in the history
  • Loading branch information
dpellier committed Jul 29, 2024
1 parent 5186bc0 commit 93569ce
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ You can update the popover content by directly updating the slot element.

# Positioning

Unlike tooltip, popover can contains focusable elements.
Unlike tooltip, popover can contain focusable elements.
Thus it needs to be positioned in the right spot on the DOM to follow the native focus workflow.

To ensure that, always declare your popover right after its trigger.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ New attribute (required).

Id of the HTML element that serves as the popover trigger.

`with-arrow` <img src="https://img.shields.io/badge/removed-FF0000" />
`with-arrow` <img src="https://img.shields.io/badge/new-008000" />

New attribute (optional).

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ export default meta;
export const Demo: StoryObj = {
render: (args) => html`
<ods-input name="input-1" style="padding-right: 8px"></ods-input>
<ods-button icon="menu-ellipsis-vertical"
id="trigger-demo"
label="Menu">
<ods-button id="trigger-demo"
label="Trigger">
</ods-button>
<ods-popover position="${args.position}"
trigger-id="trigger-demo"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ Has been removed.

You can use the new `with-arrow` attribute to render either the standard or tip previous variant.

`with-arrow` <img src="https://img.shields.io/badge/removed-FF0000" />
`with-arrow` <img src="https://img.shields.io/badge/new-008000" />

New attribute (optional).

Expand Down

0 comments on commit 93569ce

Please sign in to comment.