fix(tabs): fix controller test

ovh · Jan 16, 2024 · 6a20fac · 6a20fac
1 parent 82b3e5d
commit 6a20fac
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/packages/components/src/tabs/src/components/osds-tabs/core/controller.spec.ts b/packages/components/src/tabs/src/components/osds-tabs/core/controller.spec.ts
@@ -55,9 +55,9 @@ describe('spec:ods-tabs-controller', () => {
     });
 
     item1 = document.createElement('osds-tab-bar-item') as OsdsTabBarItem & HTMLElement;
-    item1.panel = '1';
+    item1.setAttribute('panel','1');
     item2 = document.createElement('osds-tab-bar-item') as OsdsTabBarItem & HTMLElement;
-    item2.panel = '2';
+    item2.setAttribute('panel','2');
 
     panel1 = document.createElement('osds-tabs-panel') as OsdsTabsPanel & HTMLElement;
     panel1.name = '1';
@@ -204,8 +204,8 @@ describe('spec:ods-tabs-controller', () => {
         const key = new KeyboardEvent('keypress', { code : 'ArrowRight' });
         controller.handleArrowKey(key);
 
-        expect(item1.getAttribute('active')).toEqual("");
-        expect(item2.getAttribute('active')).toEqual(null);
+        expect(item2.active).toEqual(true);
+        expect(item1.active).toEqual(false);
       });
 
       it('should set active to tab 1', () => {
@@ -215,8 +215,8 @@ describe('spec:ods-tabs-controller', () => {
         const key = new KeyboardEvent('keypress', { code : 'ArrowLeft' });
         controller.handleArrowKey(key);
 
-        expect(item2.getAttribute('active')).toEqual("");
-        expect(item1.getAttribute('active')).toEqual(null);
+        expect(item1.active).toEqual(true);
+        expect(item2.active).toEqual(false);
       });
     });
 

diff --git a/packages/components/src/tabs/src/components/osds-tabs/core/controller.ts b/packages/components/src/tabs/src/components/osds-tabs/core/controller.ts
@@ -41,10 +41,10 @@ class OdsTabsController {
   changeActivePanel(panel: string): void {
     const items = this.tabItems;
     // if not item found, select the first one
-    if (!items.find((item) => item.panel === panel) && items.length) {
-      panel = items[0].panel;
+    if (!items.find((item) => item.getAttribute('panel') === panel) && items.length) {
+      panel = items[0].getAttribute('panel')!;
     }
-    items.forEach((item) => item.active = item.panel === panel);
+    items.forEach((item) => item.active = item.getAttribute('panel') === panel);
     this.tabPanels.forEach((tabPanel) => tabPanel.active = tabPanel.name === panel);
     if (this.component.panel !== panel) {
       this.component.panel = panel;