fix(phone-number): fix review

ovh · Sep 27, 2023 · 355f250 · 355f250
1 parent 77b1957
commit 355f250
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/components/phone-number/src/components/osds-phone-number/osds-phone-number.scss b/packages/components/phone-number/src/components/osds-phone-number/osds-phone-number.scss
@@ -6,13 +6,14 @@
 }
 
 $phone-number-input-width: 236px;
+
 .phone-number {
 
   &__select {
     --ods-size-select-border-radius-bottom-right: 0;
     --ods-size-select-border-radius-top-right: 0;
     --ods-size-select-border-right-width: 0;
-    --ods-size-select-surface-width: calc(#{$phone-number-input-width} + 71px);
+    --ods-size-select-surface-width: #{$phone-number-input-width + 71px};
 
     &.opened + .phone-number__input {
       border-bottom-right-radius: 0;

diff --git a/packages/components/phone-number/src/components/osds-phone-number/osds-phone-number.tsx b/packages/components/phone-number/src/components/osds-phone-number/osds-phone-number.tsx
@@ -75,6 +75,7 @@ export class OsdsPhoneNumber implements OdsPhoneNumberAttribute, OdsPhoneNumberE
       acc.set(country.isoCode, { ...country, countryCode: exampleNumber?.getCountryCode() });
       return acc;
     }, new Map());
+    this.parsedCountries.sort((a, b) => this.sortCountriesByName(a, b));
   }
 
   @Watch('countries')
@@ -185,7 +186,7 @@ export class OsdsPhoneNumber implements OdsPhoneNumberAttribute, OdsPhoneNumberE
             }}
               slot="selectedLabel"
               class="phone-number__select-label" />
-            { this.parsedCountries?.sort((a, b) => this.sortCountriesByName(a, b)).map((country) => {
+            { this.parsedCountries.map((country) => {
               const i18nCountry = this.i18nCountriesMap?.get(country);
               return <osds-select-option value={ country } key={ country }>
                 <div class="phone-number__select__option">