Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make timeout time configurable from the control port #2

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

mlevogiannis
Copy link
Contributor

This change is backwards compatible, if the "timeout" value is not submitted to the control port then the default value of 30s will be used instead. This new option can be used to lower the time a malicious actor has to bruteforce the password.

@ramereth
Copy link
Member

@mlevogiannis I just merged some basic CI and cleanup, can you please rebase so those get triggered?

This change is backwards compatible. If a "timeout" value is not submitted
to the control port then the default value of 30s will be used.
@mlevogiannis mlevogiannis force-pushed the feature/configurable-listener-timeout branch from 41a7758 to c0811e2 Compare July 27, 2022 06:14
Copy link
Member

@ramereth ramereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge after #1 is merged

@ramereth ramereth merged commit 62da479 into osuosl:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants