Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fallback to local file detection on empty GitHub license response. #3412

Merged
merged 2 commits into from
Aug 23, 2023
Merged

🐛 fallback to local file detection on empty GitHub license response. #3412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fd2f3b
fallback to license file detection on empty API response.
spencerschrock Aug 21, 2023
c9014b3
Merge branch 'main' into fix/licenses-folder
spencerschrock Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions checks/raw/license.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,11 @@ func License(c *checker.CheckRequest) (checker.LicenseData, error) {
// repo API for licenses is supported
// go the work and return from immediate (no searching repo).
case lerr == nil:
// licenses API may be supported, but platform might not detect license same way we do
// fallback to our local file logic
if len(licensesFound) == 0 {
break
}
for _, v := range licensesFound {
results.LicenseFiles = append(results.LicenseFiles,
checker.LicenseFile{
Expand Down