Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

128-bit core binary integer support #143

Open
oscbyspro opened this issue Nov 30, 2024 · 0 comments
Open

128-bit core binary integer support #143

oscbyspro opened this issue Nov 30, 2024 · 0 comments
Labels
addition oh, so shiny! await can't be done yet

Comments

@oscbyspro
Copy link
Owner

oscbyspro commented Nov 30, 2024 •
edited
Loading

I have implemented the I128 and U128 core binary integer models on a private branch, but the Swift.Int128 and Swift.UInt128 models fail some tests. I've submitted the following pull request(s) to unblock this feature:
@oscbyspro oscbyspro added addition oh, so shiny! await can't be done yet labels Nov 30, 2024
@oscbyspro oscbyspro changed the title 128-bit (built-in) binary integer support 128-bit core binary integer support Nov 30, 2024
@oscbyspro oscbyspro mentioned this issue Dec 7, 2024
Merged
oscbyspro added a commit that referenced this issue Dec 17, 2024
@oscbyspro
This patch adds **unavailable** I128 and U128 models (#143).
db12067 
The underlying `Swift.Int128` and `Swift.UInt128` models fail some tests (crash). I have submitted some fixes that got merged into the `Swift 6.1` branch. I'll try again later and make the `I128` and `U128` available when all tests pass successfully.
@oscbyspro oscbyspro mentioned this issue Dec 17, 2024
Merged
oscbyspro added a commit that referenced this issue Dec 17, 2024
@oscbyspro
Unavailable I128 and U128 models (#152).
76d83e7 
* This patch adds **unavailable** `I128` and `U128` models (#143).

The underlying `Swift.Int128` and `Swift.UInt128` models fail some tests (crash). I have submitted some fixes that got merged into the `Swift 6.1` branch. I'll try again later and make the `I128` and `U128` available when all tests pass successfully.

* Conditionally add I128 and U128 to testing lists.

* Todos about 128-bit DoubleInt typee aliases.

* Add heterogeneous binary integer element alignment tests.

* Cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addition oh, so shiny! await can't be done yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oscbyspro