Merge pull request #117 from opentracing/fixes_with_baggage_items

fix: fixes the return type for withBaggageItems.
opentracing · Jan 5, 2021 · 31d2604 · 31d2604
2 parents d2466a2 + 450cfd9
commit 31d2604
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/OpenTracing/Mock/MockSpanContext.php b/src/OpenTracing/Mock/MockSpanContext.php
@@ -4,8 +4,8 @@
 
 namespace OpenTracing\Mock;
 
-use ArrayIterator;
 use OpenTracing\SpanContext;
+use ArrayIterator;
 
 final class MockSpanContext implements SpanContext
 {
@@ -88,7 +88,7 @@ public function getBaggageItem(string $key): ?string
     /**
      * {@inheritdoc}
      */
-    public function withBaggageItem(string $key, string $value): ?SpanContext
+    public function withBaggageItem(string $key, string $value): SpanContext
     {
         return new self($this->traceId, $this->spanId, $this->isSampled, array_merge($this->items, [$key => $value]));
     }

diff --git a/src/OpenTracing/NoopSpanContext.php b/src/OpenTracing/NoopSpanContext.php
@@ -27,7 +27,7 @@ public function getBaggageItem(string $key): ?string
     /**
      * {@inheritdoc}
      */
-    public function withBaggageItem(string $key, string $value): ?SpanContext
+    public function withBaggageItem(string $key, string $value): SpanContext
     {
         return new self();
     }

diff --git a/src/OpenTracing/SpanContext.php b/src/OpenTracing/SpanContext.php
@@ -33,5 +33,5 @@ public function getBaggageItem(string $key): ?string;
      * @param string $value
      * @return SpanContext
      */
-    public function withBaggageItem(string $key, string $value): ?SpanContext;
+    public function withBaggageItem(string $key, string $value): SpanContext;
 }