Networking: Add user defined networks EgressIP tests #29420
Conversation
For layer 2 and layer 3 primary user defined networks. Signed-off-by: Martin Kennelly <[email protected]>
|
/test e2e-gcp-ovn-techpreview |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-dualstack-techpreview /payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview |
|
@martinkennelly: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bb3525d0-cf3a-11ef-94e5-3e744d8b3b00-0 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: martinkennelly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
| g.Entry("[OCPFeatureGate:NetworkSegmentation][Feature:UserDefinedPrimaryNetworks]", networkAttachmentConfigParams{name: "l3udn", topology: "layer3", role: "primary", cidr: correctCIDRFamily(newPrivilegedEIPOC(), "30.10.0.0/16", "2014:100:200::0/60")}), | ||
| g.Entry("[OCPFeatureGate:NetworkSegmentation][Feature:UserDefinedPrimaryNetworks]", networkAttachmentConfigParams{name: "l2udn", topology: "layer2", role: "primary", cidr: correctCIDRFamily(newPrivilegedEIPOC(), "30.10.0.0/16", "2014:100:200::0/60")})) |
There was a problem hiding this comment.
It looks to me that these should be skipped for MicroShift. It does not have a networks.operator.openshift.io so GetIPAddressFamily() fails.
@pacevedom correct me if I'm wrong
There was a problem hiding this comment.
Am I right assuming that g.DescribeTableSubtree will execute code for creating the entries before the test themselves, and these entries are executing correctCIDRFamily, that now panics instead of returning an error?
The behavior I see in microshift jobs seems to go this way but I would like to confirm.
We do not have some of the apigroups you would expect in that function in microshift, and this code is executed before the automatic skipping based on feature gates, etc.
For layer 3 and layer 2 primary user defined networks.