Bug 1713098: backport prometheus client_go race fix to 4.1

[rphillips]

checkMetricConsistency relies on labels being sorted. If they are not, it is sorting them, which is modifying a slice that is assumed to be immutable elsewhere. Even if they are sorted, sort.Sort might temporarily change order (even if no equal elements are in the slice) if there are more than 12 labels (where the implementation switches from ShellSort to HeapSort or QuickSort).
Just using sort.Stable is not a solution as the immutable slice will still be mutated if it is not sorted (which can only happen with home-grown metric families, but it can still happen).

This is fixed in 4.2.

ref: prometheus/client_golang#513
ref: https://bugzilla.redhat.com/show_bug.cgi?id=1713098

[sjenning]

test clusters failed to init
/retest

[sjenning]

/approve
/lgtm

[sjenning]

fyi @deads2k

[wking]

/hold

PR subject should start with Bug 171309:, not BZ171309: to get the change-log reference link.

[deads2k]

/approve

This all looks good as long as the actual code change matches @sjenning expectations.

/assign @sjenning

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [deads2k,sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sjenning]

PR subject has been fixed
/hold cancel

[wking]

nooo, we got openshift/release#3790 just too late to catch my #23035 (comment) dropping an 8 and therefore linking us to some 2005 Fedora bug 😭 Ah, well...

[openshift-ci-robot]

@rphillips: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1713098: backport prometheus client_go race fix to 4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rphillips]

@wking sorry. missed that 8.