Reconcile ScanSettingBindings when a TailoredProfile changes #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case a TailoredProfile was valid, but then modified to be invalid, the configMap is still around. This is at best confusing and maybe even dangerous as existing scans will just happily carry on using that CM. Let's remove the configMap when the tailoredProfile is marked as invalid. Related: #791
openshift-ci
bot
added
the
approved
|
/retest |
Vincent056
approved these changes
Feb 9, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhrozek, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Modifies the ScanSettingBinding controller to also watch for TailoredProfile CRs which link to a TP. This allows to reconcile ScanSettingBindings in case a TailoredProfile is modified, typically after fixing issues in a TailoredProfile without having to recreate the TailoredProfile. Fixes: #791
|
/retest |
|
@jhrozek: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the ScanSettingBinding controller to also watch for
TailoredProfile CRs which link to a TP. This allows to reconcile
ScanSettingBindings in case a TailoredProfile is modified, typically
after fixing issues in a TailoredProfile without having to recreate the
TailoredProfile.
Fixes: #791
NOTE: I haven't had the chance to test the e2e addition at all. Feedback is welcome
in the meantime and maybe the tests will even pass :-)